[Windows][kinetic-devel] Use the portable way to decide the line break. #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brawner @dirk-thomas This is ready for review and merge. Thanks! |
brawner
reviewed
Feb 4, 2020
seanyen
changed the title
brawner
approved these changes
Feb 4, 2020
|
@brawner @dirk-thomas Friendly ping. |
|
Thanks for the patch. |
dirk-thomas
pushed a commit
that referenced
this pull request
Feb 28, 2020
…k. (#200) * Use portable way to decide the line break. https://docs.python.org/3/library/os.html#os.linesep * Address feedback.
|
Cherry-picked to |
|
This PR introduced a flake8 failure in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the portable
os.linesepinstead of hard-coded\nline break increate_dot. The long lines with line break are not really replaced on Windows environment.