qt_dotgraph: Allow custom edge style #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -180,6 +180,7 @@ def addEdgeItem(self, edge, nodes, edges, highlight_level, same_label_siblings=F | |||
| if 'style' in edge.attr: | |||
| if edge.attr['style'] == 'invis': | |||
| return | |||
| style = edge.attr.get('style', 'solid') | |||
There was a problem hiding this comment.
Since yoo choose the default also in the EdgeItem this line should not define a default but None instead.
|
Did all suggested changes. Thanks for reviewing! |
| self._text_brush = QBrush(self._default_color) | ||
| self._shape_brush = QBrush(self._default_color) | ||
| if style in ['dashed', 'dotted']: | ||
| self._shape_brush = QBrush(Qt.transparent) |
There was a problem hiding this comment.
Why does the shape need to be transparent in these cases?
There was a problem hiding this comment.
Otherwise, the triangular shape at the end of the arrow has a dashed border but a black fill. What looks strange.
|
Thanks! |
dirk-thomas
added a commit
that referenced
this pull request
Feb 2, 2015
qt_dotgraph: Allow custom edge style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow 'dashed' and 'dotted' edge styles.