Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test improvements #53

Merged
merged 3 commits into from
Apr 30, 2015
Merged

Test improvements #53

merged 3 commits into from
Apr 30, 2015

Conversation

galou
Copy link

@galou galou commented Feb 4, 2015

Add python-pygraphviz as test_depend for qt_dotgraph. Shouldn't it be rather included as run_depend for the pygraphvizfactory module to work out-of-the box for potential users?

Add condition around catkin_add_nosetests

Fix PyDotFactoryTest.test_create_dot

@dirk-thomas
Copy link
Contributor

Sorry for dropping the ball on this. This is definitely an improvement. Thanks!

dirk-thomas added a commit that referenced this pull request Apr 30, 2015
@dirk-thomas dirk-thomas merged commit 10bf738 into ros-visualization:groovy-devel Apr 30, 2015
@galou galou deleted the test_improvements branch April 30, 2015 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants