qt_dotgraph: Small fixes for Python3 compatibility #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirk-thomas
reviewed
Jul 10, 2017
| @@ -135,7 +135,9 @@ def getNodeItemForNode(self, node, highlight_level): | |||
| if name is None: | |||
| print("Error, no label defined for node with attr: %s" % node.attr) | |||
| return None | |||
| name = name.decode('string_escape') | |||
|
|
|||
| import codecs # To work with Python 2 and 3 (https://stackoverflow.com/a/23151714) | |||
There was a problem hiding this comment.
Can you please move the import to the top of the file (between line 32 and 33) and remove the comment.
There was a problem hiding this comment.
@kartikmohta Can you please make this small adjustment in order to get this patch merged.
dirk-thomas
reviewed
Jul 19, 2017
| @@ -53,7 +53,7 @@ def check_x_server(): | |||
|
|
|||
| class DotToQtGeneratorTest(unittest.TestCase): | |||
|
|
|||
| DOT_CODE = ''' | |||
| DOT_CODE = r''' | |||
There was a problem hiding this comment.
Can you please explain why this change is necessary?
There was a problem hiding this comment.
There is a '\N' in the string and that causes issues with Python3 since it tries to parse that as a unicode control character. To avoid that, it needs to be specified to be a raw string.
$ python3
>>> print('\N')
File "<stdin>", line 1
SyntaxError: (unicode error) 'unicodeescape' codec can't decode bytes in position 0-1: malformed \N character escape
>>> print(r'\N')
\N
There was a problem hiding this comment.
Thanks for clarifying.
|
Thank you for improving Python 3 support! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly to get
rqt_graphworking with Python3. ros-visualization/rqt_graph#10 is also required forrqt_graphto work with Python3.