Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rqt scripts installed to global PATH #68

Closed
tkruse opened this issue Feb 5, 2013 · 4 comments
Closed

rqt scripts installed to global PATH #68

tkruse opened this issue Feb 5, 2013 · 4 comments

Comments

@tkruse
Copy link
Contributor

tkruse commented Feb 5, 2013

I assume this was done in the migration to Groovy, but most or all of those scripts should not be installed to the PATH:
['rqt', 'qt_gui_app', 'rqt_bag', 'rqt_console', 'rqt_graph', 'rqt_logger_level', 'rqt_plot', 'rqt_reconfigure']
dirk-thomas added a commit to ros-visualization/qt_gui_core that referenced this issue Feb 5, 2013
@dirk-thomas
install qt_gui_app into package specific bin folder (ros-visualizatio…
4ab37ea 
…n/rqt#68)
@dirk-thomas
Copy link
Contributor

rqt and the core tools previous available as rx* are intentionally still on the path. qt_gui_app has been moved to package specific bin folder.

@130s
Copy link
Member

130s commented Feb 5, 2013

Technically reconfigure GUI wasn't in rx suite but in dynamic_reconfigure. I'm ok with either to delete from PATH or to keep it as it is.

@dirk-thomas
Copy link
Contributor

@130s: can you check if it was on the path before and if not remove the script from setup.py?

@130s 130s reopened this Feb 6, 2013
@130s
Copy link
Member

130s commented Feb 6, 2013

It was added in 24c16b05cf5792cdb417afd896a274486cf69775 by me without considering rx orientation.
Should be removed from PATH via ros-visualization/rqt_common_plugins@2311693#rqt_reconfigure/setup.py

@130s 130s closed this as completed Feb 6, 2013
@vrabaud vrabaud mentioned this issue Mar 11, 2013
Closed
DLu pushed a commit to DLu/rqt_common_plugins that referenced this issue Aug 14, 2015
@130s
rqt_reconfigure) Fix to ros-visualization/rqt#68 (comment)
2311693
dirk-thomas pushed a commit to ros-visualization/rqt_reconfigure that referenced this issue Apr 24, 2017
@130s
rqt_reconfigure) Fix to ros-visualization/rqt#68 (comment)
3ee50f5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dirk-thomas @tkruse @130s