Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work on Melodic #27

Closed
VictorLamoine opened this issue Jun 5, 2018 · 4 comments
Closed

Does not work on Melodic #27

VictorLamoine opened this issue Jun 5, 2018 · 4 comments

Comments

@VictorLamoine
Copy link
Contributor

VictorLamoine commented Jun 5, 2018

  • Kubuntu 18.04
  • ROS Melodic
$ dpkg -l | grep rqt_bag
ii  ros-melodic-rqt-bag                             0.4.12-0bionic.20180522.045045              amd64        rqt_bag provides a GUI plugin for displaying and replaying ROS bag files.
ii  ros-melodic-rqt-bag-plugins                     0.4.12-0bionic.20180522.162523              amd64        rqt_bag provides a GUI plugin for displaying and replaying ROS bag files.

I can open a bag file but I cannot see any contents inside:

Exception in thread Thread-7:
Traceback (most recent call last):
  File "/usr/lib/python2.7/threading.py", line 801, in __bootstrap_inner
    self.run()
  File "/opt/ros/melodic/lib/python2.7/dist-packages/rqt_bag/timeline_cache.py", line 74, in run
    msg_stamp, item = self.loader(topic, stamp, item_details)
  File "/opt/ros/melodic/lib/python2.7/dist-packages/rqt_bag_plugins/image_timeline_renderer.py", line 160, in _load_thumbnail
    msg_topic, msg, msg_stamp = bag._read_message(pos)
  File "/opt/ros/melodic/lib/python2.7/dist-packages/rosbag/bag.py", line 1299, in _read_message
    return self._reader.seek_and_read_message_data_record(position, raw)
TypeError: seek_and_read_message_data_record() takes exactly 4 arguments (3 given)

Exception in thread Thread-15:
Traceback (most recent call last):
  File "/usr/lib/python2.7/threading.py", line 801, in __bootstrap_inner
    self.run()
  File "/opt/ros/melodic/lib/python2.7/dist-packages/rqt_bag/message_loader_thread.py", line 83, in run
    msg_data = self._get_message(bag, playhead_position)
  File "/opt/ros/melodic/lib/python2.7/dist-packages/rqt_bag/message_loader_thread.py", line 96, in _get_message
    msg_data = self.timeline.read_message(bag, position)
  File "/opt/ros/melodic/lib/python2.7/dist-packages/rqt_bag/bag_timeline.py", line 481, in read_message
    return bag._read_message(position)
  File "/opt/ros/melodic/lib/python2.7/dist-packages/rosbag/bag.py", line 1299, in _read_message
    return self._reader.seek_and_read_message_data_record(position, raw)
TypeError: seek_and_read_message_data_record() takes exactly 4 arguments (3 given)

In the GUI:

  • The thumbnails do not work
  • The topics cannot be displayed as raw (the created panel stays empty)
  • The topics cannot be displayed as images (the created panel stays empty)
  • Plotting the data crashes rqt_bag

Example bag file:
http://wiki.ros.org/ethzasl_sensor_fusion/Tutorials/getting_started?action=AttachFile&do=view&target=dataset.bag

@VictorLamoine
Copy link
Contributor Author

I don't understand this error as the definition only seems to take 3 arguments:
https://github.com/ros/ros_comm/blob/melodic-devel/tools/rosbag/src/rosbag/bag.py#L2358

Can someone confirm this bug?

@lalten
Copy link

lalten commented Jun 8, 2018

I have the exact same problem, with both the 0.4.12-0bionic.20180522.045045 debian package and the 0.4.12 git master. Did you find a solution?

@lalten
Copy link

lalten commented Jun 8, 2018

Apparently ros_comm PR #1372 broke this. If you revert commit 752cf1f8bf3a17560f5d496609fadab2ebffd121 in ros_comm, rqt_bag works as expected again.

@dirk-thomas
Copy link
Contributor

Closing as duplicate of ros/ros_comm#1432.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants