Fix rosbag's internal _read_message API #1444
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dirk-thomas I don't understand why the checks failed. It seems like it doesn't have to do anything with the code. Is the Github API is broken? |
|
@dirk-thomas Sorry to ping but this issue is quite annoying, it forces to compile Either this merge request or #1445 does the job. |
|
@dirk-thomas @tfoote See previous message |
|
Closing in favor of #1473. |
|
Thank you for contributing the patch - the commits are part of the combined PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the internal rosbag API used by rqt_bag, which was broken with PR #1372
This closes #1432 and ros-visualization/rqt_bag#27