Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the tree controls in the Raw View and Plot View consistent #57

Merged
merged 4 commits into from
Oct 8, 2020
Merged

Make the tree controls in the Raw View and Plot View consistent #57

merged 4 commits into from
Oct 8, 2020

Conversation

mjeronimo
Copy link
Contributor

Remove inconsistencies. Also, add a header for the tree widget to display the message type.

mjeronimo and others added 3 commits October 5, 2020 12:31
Ctrl-A expands and selects all items. Ctrl-C copies all items.

Previously, there was an issue with Ctrl-A in the raw view where
if you highlighted an unexpanded node with children and hit Ctrl-A,
the currently highlighted node would not itself expand. Now, all
nodes expand and are highlighted.
It doesn't take up much space and is a convenient reminder
about the message type.
@mjeronimo mjeronimo self-assigned this Oct 5, 2020
Copy link
Contributor

@dirk-thomas dirk-thomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beside some minor comments this lgtm.

rqt_bag_plugins/src/rqt_bag_plugins/plot_view.py Outdated Show resolved Hide resolved
rqt_bag_plugins/src/rqt_bag_plugins/plot_view.py Outdated Show resolved Hide resolved
rqt_bag_plugins/src/rqt_bag_plugins/plot_view.py Outdated Show resolved Hide resolved
Copy link

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mjeronimo mjeronimo merged commit a591e2d into ros-visualization:master Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants