Fix raw view #94
Merged
Fix raw view #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mjeronimo do you remember why you touched raw view in an image_view PR? |
|
Maybe I should add that this is a fix for Melodic. Not tested on Noetic. Could that be the reason why the encode was added? |
|
@peci1 Yes, please test on Kinetic and Noetic as well, if you would. If I recall the code did need to be slightly different for each. |
|
So, Noetic doesn't need this PR. I'll test on Kinetic later. |
|
Kinetic requires this PR. |
|
I updated this PR with a version that works on Kinetic, Melodic and Noetic. |
mjeronimo
approved these changes
Feb 11, 2021
|
Thanks ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #92. Partly reverts #68.
I never know with the encode/decode things, but this is what fixed raw view for me.