Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a few minor issues in image_helper #68

Merged
merged 3 commits into from
Oct 29, 2020
Merged

Fix a few minor issues in image_helper #68

merged 3 commits into from
Oct 29, 2020

Commits on Oct 28, 2020

  1. Fix a few minor issues in image_helper 

    * Used ByteIO rather than StringIO is now required for PIL's Image.open
* Remove unused variable, 'alpha'
* Added support for '8UC1' and '32FC1' image types
* Only do bgr2rgb if it's definitely a BGR type

Fixes #60

Signed-off-by: Michael Jeronimo <michael.jeronimo@openrobotics.org>
    @mjeronimo
    mjeronimo committed Oct 28, 2020
    Configuration menu
    Copy the full SHA
    8a3f217 View commit details
    Browse the repository at this point in the history

  2. Add a missing encode() call

    @mjeronimo
    mjeronimo committed Oct 28, 2020
    Configuration menu
    Copy the full SHA
    fafe2ee View commit details
    Browse the repository at this point in the history

  3. Invert 32F depth images so that closer is lighter and farther is darker 

    Signed-off-by: Michael Jeronimo <michael.jeronimo@openrobotics.org>
    @mjeronimo
    mjeronimo committed Oct 28, 2020
    Configuration menu
    Copy the full SHA
    9f26c06 View commit details
    Browse the repository at this point in the history