Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix merge sort in bag export. #96

Merged
merged 2 commits into from
Feb 18, 2021

Conversation

MichaelGrupp
Copy link
Contributor

@MichaelGrupp MichaelGrupp commented Feb 17, 2021

Follow up to #93.

A bit more changes were necessary to keep track of the corresponding bag files
for each entry.

Tested on Noetic with two overlapping bagfiles.

@MichaelGrupp
Copy link
Contributor Author

Crap, heapq.merge has no key argument in Python 2...

@MichaelGrupp
Copy link
Contributor Author

Now it should also work on ROS Melodic. Would be great if someone could confirm this.

@mjeronimo
Copy link
Contributor

@MichaelGrupp I was unable to reproduce an issue on Melodic. I tried to create overlapping bag files, load into rqt_bag and then export to a new bag file. Can you please provide the sequence of steps to reproduce and some sample bag files, if possible? Thanks.

@MichaelGrupp
Copy link
Contributor Author

MichaelGrupp commented Feb 18, 2021

The issue doesn't happen on ROS Melodic because the removal of this rosbag.bag._mergesort function was not released for Melodic, only Noetic. As far as I understand, rqt_bag is published for both Melodic and Noetic from the master branch so we need to ensure that this patch works for both Python 2 and 3, although the bug itself doesn't exist in Melodic.

@mjeronimo
Copy link
Contributor

Ah, OK. Thanks for the info. I'll try the patch on Melodic.

@mjeronimo
Copy link
Contributor

Works fine on Melodic.

@mjeronimo mjeronimo merged commit 98352a6 into ros-visualization:master Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants