Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rqt_bag: when moving a viewer, it cannot be resized anymore #306

Closed
suryaambrose opened this issue Mar 20, 2015 · 8 comments
Closed

rqt_bag: when moving a viewer, it cannot be resized anymore #306

suryaambrose opened this issue Mar 20, 2015 · 8 comments

Comments

@suryaambrose
Copy link
Contributor

Open any viewer (raw for instance). The viewer opens on the right of rqt_bag. It can be resized, the viewer will adapt.
Grab the viewer and move it to the bottom of the window (or anywhere else). Then try to resize it => it won't move. If you bring it back to its original position, it will still not resize.

ghost pushed a commit to suryaambrose/rqt_common_plugins that referenced this issue Mar 20, 2015
@ablasdel
Copy link
Contributor

Wow that is a serious flaw. I'm surprised I didn't ever run into it.

Does it only happen with the bottom Or is it any other snapped location?
Does this happen every time?
Are you running in stand alone mode? If not are there any other plugins running?

This is how to reproduce correct?
Open rqt_bag
Open raw viewer
Reposition raw viewer to snapped in below rqt_bag
Try to resize raw viewer and you will be unable to.

@suryaambrose
Copy link
Contributor Author

Any other snapped location and yes it happens all the time.
I run rqt_bag in stand alone mode and your protocol is correct :).

@suryaambrose
Copy link
Contributor Author

The bug is not that old (september 2014).

Here is a picture where you can see that the viewer did not resize when I moved it at the bottom. This behavior will remain even if I move the viewer back to the right.
not_resized

This would be the expected behavior
resized

@ablasdel
Copy link
Contributor

Ok if you can figure out how to fix it it would be awesome if you could submit a patch. If not I'll take a look when I can get some time (not sure when that will be at the moment. )

Does moving the raw viewer out to a floating window after it gets stuck fix it?

If not for now the work around is Don't do that! ^_^

@suryaambrose
Copy link
Contributor Author

Hum I don't know about your question, I did not try, but I just submitted a patch anyway :)

@ablasdel
Copy link
Contributor

Are you a wizard?

Ok I'll try to get some time to review this. The new work around is use the pull request!

Thanks suryaambrose!

@trainman419
Copy link
Contributor

I've confirmed that I can reproduce this.

ghost pushed a commit to suryaambrose/rqt_common_plugins that referenced this issue Mar 30, 2015
ghost pushed a commit to suryaambrose/rqt_common_plugins that referenced this issue Mar 30, 2015
ghost pushed a commit to suryaambrose/rqt_common_plugins that referenced this issue Mar 31, 2015
ghost pushed a commit to suryaambrose/rqt_common_plugins that referenced this issue Mar 31, 2015
ghost pushed a commit to suryaambrose/rqt_common_plugins that referenced this issue Mar 31, 2015
ablasdel added a commit that referenced this issue Mar 31, 2015
Fix viewer plugin relocation issue (#306)
@trainman419
Copy link
Contributor

I think this is fixed now that #307 is merged.

@ablasdel ablasdel closed this as completed Apr 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants