Add "From nodes" button to rqt_bag record mode like "rosbag record --node" #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirk-thomas
added a commit
that referenced
this pull request
Sep 9, 2016
|
It would be nicer if the node selection would happen within the same modal dialog instead of opening another one. But since the new feature is certainly useful and doesn't impact the existing functionality it was merged as is. It can always be improved in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add node selection window when rqt_bag is used in record mode like
rosbag record --node.User can select node instead of topic to record and rqt_bag automatically
record the topics which the selected nodes are subscribing.