Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rqt_graph crashes on kinetic if (enable_statistics == true) #428

Closed
jrahlf opened this issue Feb 7, 2017 · 1 comment
Closed

rqt_graph crashes on kinetic if (enable_statistics == true) #428

jrahlf opened this issue Feb 7, 2017 · 1 comment

Comments

@jrahlf
Copy link

jrahlf commented Feb 7, 2017

Hi,

for me rqt_graph crashes on kinetic, if the rosparam enable_statistics has been set to true.

See the attached log for details.

$ rqt_graph 
PluginHandlerDirect._restore_settings() plugin "rqt_graph/RosGraph#0" raised an exception:
Traceback (most recent call last):
  File "/opt/ros/kinetic/lib/python2.7/dist-packages/qt_gui/plugin_handler_direct.py", line 116, in _restore_settings
    self._plugin.restore_settings(plugin_settings_plugin, instance_settings_plugin)
  File "/home/dyecam/catkin_ws/install_isolated/lib/python2.7/dist-packages/rqt_graph/ros_graph.py", line 203, in restore_settings
    self._refresh_rosgraph()
  File "/home/dyecam/catkin_ws/install_isolated/lib/python2.7/dist-packages/rqt_graph/ros_graph.py", line 227, in _refresh_rosgraph
    self._update_graph_view(self._generate_dotcode())
  File "/home/dyecam/catkin_ws/install_isolated/lib/python2.7/dist-packages/rqt_graph/ros_graph.py", line 254, in _generate_dotcode
    quiet=quiet)
  File "/home/dyecam/catkin_ws/install_isolated/lib/python2.7/dist-packages/rqt_graph/dotcode.py", line 578, in generate_dotcode
    quiet=quiet)
  File "/home/dyecam/catkin_ws/install_isolated/lib/python2.7/dist-packages/rqt_graph/dotcode.py", line 521, in generate_dotgraph
    self._add_edge(e, dotcode_factory, dotgraph=dotgraph, is_topic=(graph_mode == NODE_NODE_GRAPH))
  File "/home/dyecam/catkin_ws/install_isolated/lib/python2.7/dist-packages/rqt_graph/dotcode.py", line 213, in _add_edge
    [stat_label, penwidth, color] = self._calc_statistic_info(sub, topic)
  File "/home/dyecam/catkin_ws/install_isolated/lib/python2.7/dist-packages/rqt_graph/dotcode.py", line 175, in _calc_statistic_info
    pub = next(self.edges[sub][topic].keys())
TypeError: list object is not an iterator

rqt-crash.txt

Kind regards

@dirk-thomas
Copy link
Contributor

I can't reproduce the problem. Can you please provide more information (which exact version of rqt_graph as well as qt_dotgraph are you using?) and a reproducible example (http://sscce.org/).

sosswald added a commit to sosswald/rqt_common_plugins that referenced this issue Mar 2, 2017
dirk-thomas added a commit that referenced this issue Mar 2, 2017
Fix crash of rqt_graph when enable_statistics == true, fixes #428
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants