Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][rqt_bag_plugins] 'image_helper' is not defined" error. #426

Merged

Conversation

130s
Copy link
Member

@130s 130s commented Feb 1, 2017

Similar to #424, without this PR I get the following error when I click Toggle Thumbnail button after loading a .bag file that contains image topics.

$ rqt&
$ Loading /home/rosnoodle/Desktop/2017-01-30-15-03-19.bag
Done loading /home/rosnoodele/Desktop/2017-01-30-15-03-19.bag
Error loading image on topic /camera/image_raw: global name 'image_helper' is not defined
Disabling renderer on /camera/image_raw

$ rospack find rqt_bag
/home/rosnoodele/cws_viz/src/ros-visualization/rqt_common_plugins/rqt_bag
$ roscd rqt_bag
$ git log
commit 2c2487a02c83628a14be7bde318d20249167ffdb
Author: Dirk Thomas <dthomas@osrfoundation.org>
Date:   Tue Jan 31 12:35:55 2017 -0800

    fix bag_helper import
:

(For testing I used this bag file that contains images (500+MB though, and URL will likely change soon).

@130s
Copy link
Member Author

130s commented Feb 1, 2017

Tested on Indigo - Python2 only. About to test on Kinetic now.

@dirk-thomas
Copy link
Contributor

Reviewing the PR #421 which introduced the regressions it looks like this line needs the same fix:

import rqt_bag_plugins.image_helper

Could you please update this PR to fix that line too.

@dirk-thomas dirk-thomas added the bug label Feb 1, 2017
…w: global name 'image_helper' is not defined".
@130s
Copy link
Member Author

130s commented Feb 1, 2017

Ok, rqt_bag_plugins/image_view.py is changed too.

On my Kinetic I have a Qt issue that has nothing to with the issue here, so I'm not able to test this for now. If someone can test that'll be great.

@dirk-thomas
Copy link
Contributor

Thanks for patch.

@dirk-thomas dirk-thomas merged commit 9741d29 into ros-visualization:master Feb 1, 2017
@130s 130s deleted the fix/bag_helper_notdefined branch February 1, 2017 19:27
@130s
Copy link
Member Author

130s commented Feb 1, 2017

Confirmed on Kinetic too that the issue raised is fixed with this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants