[galactic] Fix quiet filtering for node_topic graphs #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hidmic
approved these changes
Oct 4, 2021
|
Alright, going in! Thanks for the fix @DLu. |
|
@DLu would you mind to sign off your commit before I merge? |
Signed-off-by: David V. Lu <davidvlu@gmail.com>
DLu
force-pushed
the
quiet_filtering_galactic
branch
from
aa8f5ba
to
9b66e69
Compare
|
Done |
|
@hidmic How do you want to backport? I can open up new PRs if you want |
A backport PR for Foxy sounds good. We can run Foxy CI there. |
DLu
added a commit
to DLu/rqt_graph
that referenced
this pull request
Oct 5, 2021
Signed-off-by: David V. Lu <davidvlu@gmail.com>
hidmic
pushed a commit
that referenced
this pull request
Oct 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New version of PR #69 based on galactic-devel
Here's a standard graph with Debug/Quiet=False
However, when we turn on Debug/Quiet, we are not correctly filtering the edges.
This is an effect of the nodes being properly filtered, but the edges not being filtered, so new nodes with the dot node names (
t__rosout) are created.The new logic always filters the edges (instead of just when
graph_mode == NODE_NODE_GRAPH. We also always filter thent_nodes, which is just empty ifgraph_mode == NODE_NODE_GRAPH.@hidmic I think you wrote this bit of logic originally in #35