Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small cleanups to rqt_msg #16

Merged
merged 3 commits into from
Jun 5, 2023
Merged

Small cleanups to rqt_msg #16

merged 3 commits into from
Jun 5, 2023

Conversation

clalancette
Copy link

There are 3 commits in here:

  1. Cleanup the dependencies and description of the package.
  2. Add in flake8 and xmllint tests, and fix up the resulting issues.
  3. Fix a bug where looking for an unknown message would cause a crash.

@clalancette
Copy link
Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@clalancette
Cleanup.
4dae3ef 
Make sure to add all dependencies explicitly, remove dead code,
and put some imports in order.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
@clalancette
Add in flake8 and xmllint tests and fix issues.
4de3691 
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
@clalancette
Revamp refresh_msgs to handle failures.
ba21a1f 
If one of the get{message,service,action}_interfaces methods
returns an empty dict, we want to gracefully handle it and
not crash.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
@clalancette
Copy link
Author

New CI, since I rebased this and the old one expired:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@clalancette clalancette merged commit 1ddf70b into rolling Jun 5, 2023
1 check passed
@clalancette clalancette deleted the clalancette/cleanup branch June 5, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveMacenski SteveMacenski SteveMacenski approved these changes

@methylDragon methylDragon Awaiting requested review from methylDragon methylDragon is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@clalancette @SteveMacenski