Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in copyright tests to rqt_plot. #95

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

clalancette
Copy link

There are 2 reasons to do this:

  1. All packages really should enforce copyright and license notices; this PR brings us into compliance with the rest of our code.
  2. By having at least one test here, we work around the fact that we can't import PyQt on Windows Debug. In particular, if you don't specify anything, then pytest will attempt to import everything and find tests. By specifically telling it where to find tests with a pytest.ini file, we ensure it only ever runs there. To lift this restriction in the future we'd have to figure out how to make PyQt work on Windows Debug.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
@clalancette
Copy link
Author

The combination of this and ros-visualization/rqt_bag#154 should fix the build on Windows Debug. @claraberendsen FYI

@clalancette
Copy link
Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status
  • Windows Debug Build Status

@ahcorde ahcorde changed the title Add in copyright tests to rqt_bag. Add in copyright tests to rqt_plot. Mar 27, 2024
@clalancette clalancette merged commit aa3ec19 into rolling Mar 27, 2024
1 check passed
@clalancette clalancette deleted the clalancette/add-copyright-test branch March 27, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants