Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

foxy bug #27

Closed
simulacrus opened this issue Apr 23, 2021 · 4 comments
Closed

foxy bug #27

simulacrus opened this issue Apr 23, 2021 · 4 comments
Labels

Comments

@simulacrus
Copy link

I tested the foxy-devel branch and found that rqt_publisher doesn't responding to a change in a message. I think the problem is in commit where _change_publisher_expression was deleted but https://github.com/ros-visualization/rqt_publisher/blob/foxy-devel/src/rqt_publisher/publisher.py#L158 doesn't change

@coalman321
Copy link

This issue is now in the release versions as well. I cannot change the message data being sent form the default values of the message. This applies to version 1.1.1 released on 4/23 and available through the ros 2 ppas.

Default message status:
image
taken after re-loading rqt and enabling publisher and subscriber.

updated message:
image
taken after changing message data to true.

@coalman321
Copy link

Specifically it looks like this commit was the one that removed the change handler 367049e
But this is definitely a bit of an issue, as it makes this plugin near useless.

@coalman321
Copy link

coalman321 commented May 26, 2021

I have now confirmed that reverting that specific commit fixes the issue. So the removed code was not in fact dead code... Ill open up a PR in a minute or so that fixes this against foxy-devel.
Opened PR #28

@ivanpauno
Copy link

#28 fixed the issue, thanks @coalman321 !!

I've released the fixed version for foxy/galactic/rolling:

so the issue will be fixed in next patch release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants