Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Do not ignore field values introduced by the user #28

Merged
merged 1 commit into from
Jun 29, 2021

Conversation

coalman321
Copy link

This PR reverts a commit that removed code integral to changing the published values. This change affects versions 1.1.1 and forward.

@ShotaAk
Copy link

ShotaAk commented Jun 29, 2021

I am looking forward to seeing this change merged.
Are there no reviewers?

@coalman321
Copy link
Author

@ivanpauno @jacobperron Could someone look this over and get it merged or create a fix with the intended way? In its current state, the lack of the ability to publish anything from the publisher tool makes it a bit useless.

@ivanpauno
Copy link

I will take a look.
@coalman321 could you share a minimal example to reproduce the issue?

@ivanpauno ivanpauno self-assigned this Jun 29, 2021
@ivanpauno ivanpauno added the bug label Jun 29, 2021
@ivanpauno
Copy link

Ah sorry, I see #27

@ivanpauno ivanpauno changed the title revert commit 367049ecc4ce3cabed9d5ca452fb478a98a3ba21 Fix: Do not ignore field values introduced by the user Jun 29, 2021
@ivanpauno
Copy link

Sorry, this was my bad, thanks for the fix @coalman321!!

@ivanpauno ivanpauno merged commit 1db4d5c into ros-visualization:foxy-devel Jun 29, 2021
@coalman321
Copy link
Author

All good! Thanks for getting this fix back into mainline. How long should we expect for it to hit the PPA's?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants