Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary parentheses around if statements. #140

Merged
merged 1 commit into from Jan 26, 2024
Merged

Remove unnecessary parentheses around if statements. #140

merged 1 commit into from Jan 26, 2024

Conversation

clalancette
Copy link

@clalancette clalancette commented Jan 25, 2024 •
edited

This will make newer flake8 happy.

@clalancette
Remove unnecessary parentheses around if statements.
ffbe999 
This will make newer flake8 happy.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
@clalancette clalancette changed the base branch from master to rolling January 25, 2024 20:37
@clalancette clalancette changed the title Clalancette/fix flake8 warnings Remove unnecessary parentheses around if statements. Jan 25, 2024
quarkytale
quarkytale approved these changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@quarkytale quarkytale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, not sure why noetic is failing

@clalancette
Copy link
Author

LGTM, not sure why noetic is failing

Ah, I made a mistake when I opened it and opened the PR against the master branch. That kicked off the Noetic build, but it won't possibly work; this code is all for ROS 2. So we can safely ignore that.

@clalancette
Copy link
Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@clalancette clalancette merged commit 055db41 into rolling Jan 26, 2024
2 of 3 checks passed
@clalancette clalancette deleted the clalancette/fix-flake8-warnings branch January 26, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatthijsBurgh MatthijsBurgh MatthijsBurgh approved these changes

@quarkytale quarkytale quarkytale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@clalancette @MatthijsBurgh @quarkytale