battery_dash_widget: Tooltip states name of battery. #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
battery_dash_widget: float values are rounded.
ghost
assigned 
|
It'll be the middle of next week when I'll be able to test with robots. I still can test if there are any simulations available. Any idea? |
|
As that uses diagnostics or similar I don't think that's simulated anywhere (besides sending manual messages). I also tested it by just switching on the robot. |
130s
pushed a commit
that referenced
this pull request
Apr 25, 2013
I confirmed that the proposed part (to avoid float value rounded) works, by unit test file I'll upload later. I haven't been able to test With real robots -- I only have an access to `PR2`, of which dashboard overrides `BatteryDashWidget`.`update_time` method.
|
A simple unit test is uploaded via 342ffe7 |
dirk-thomas
pushed a commit
to ros-visualization/rqt_robot_dashboard
that referenced
this pull request
Apr 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
battery_dash_widget: float values are rounded.