Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ROS Noetic 20.04 Fix dot save according to the PyQt5 #28

Merged
merged 1 commit into from
Nov 13, 2021
Merged

ROS Noetic 20.04 Fix dot save according to the PyQt5 #28

merged 1 commit into from
Nov 13, 2021

Conversation

cosmicog
Copy link

Couldn't save a dot graph without this with Noetic
http://pyqt.sourceforge.net/Docs/PyQt5/incompatibilities.html

@mabelzhang mabelzhang changed the base branch from master to noetic-devel November 13, 2021 01:28
mabelzhang
mabelzhang approved these changes Nov 13, 2021
View reviewed changes
Copy link
Contributor

@mabelzhang mabelzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I tested this on Noetic and Melodic.
It works on Noetic, but does not work on Melodic - on Melodic, the original code works fine and the PR actually makes it error.
So I've created a noetic-devel branch and retargeted this PR.

@mabelzhang mabelzhang merged commit 850c51a into ros-visualization:noetic-devel Nov 13, 2021
arne48 added a commit that referenced this pull request Oct 2, 2023
@arne48
Fix dot save according to the PyQt5 (#28)
89e6114
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mabelzhang mabelzhang mabelzhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cosmicog @mabelzhang