rviz segfaults in wxSafeYield (ros-pkg ticket #5159)

[hershwg]

rViz segfaults during the splash screen with this:

{{{
[ INFO] [1315779050.076427000]: Loading general config from [/Users/william/Library/Preferences/.rviz/config]
[ INFO] [1315779050.077706000]: Loading display config from [/Users/william/Library/Preferences/.rviz/display_config]

Program received signal EXC_BAD_ACCESS, Could not access memory.
Reason: KERN_INVALID_ADDRESS at address: 0x0000000000000050
0x000000010375e8ba in wxGUIEventLoop::BeginModalSession ()
(gdb) bt
#0 0x000000010375e8ba in wxGUIEventLoop::BeginModalSession ()
#1 0x000000010375ebc3 in wxWindowDisabler::DoDisable ()
#2 0x0000000103667721 in wxSafeYield ()
#3 0x0000000102d6c4fc in rviz::SplashScreen::setState (this=0x108001000, state=@0x7fff5fbfcef8) at splash_screen.cpp:63
#4 0x0000000102df6d35 in rviz::VisualizationFrame::initialize (this=0x108008a00, display_config_file=@0x7fff5fbfe8a8, fixed_frame=@0x7fff5fbfe898, target_frame=@0x7fff5fbfe8a0, splash_path=@0x7fff5fbfe890, verbose=false) at visualization_frame.cpp:174
#5 0x00000001000247f4 in rviz::VisualizerApp::OnInit (this=0x105d4b570) at visualizer_app.cpp:253
#6 0x00000001036edb2b in wxApp::CallOnInit ()
#7 0x000000010357f404 in wxEntry ()
#8 0x000000010000fab4 in main (argc=1, argv=0x7fff5fbff190) at visualizer_app.cpp:340

}}}

I looked into this and I think this function (wxSafeYield(wxFrame*,bool)) was deprecated in wx-2.8 and causes the crash in wx-2.9. Either way removing it does not cause any problems that I can tell. There is still a wxSafeYield and wxYield, but they only exist for wxApp:: and wxAppConsole::.

The attached patch simply removes the line in question and is tested on OS X 10.7. I will test Linux ASAP.

trac data:

• Owner: hersh
• Reporter: wjwwood
• Reported at: Sun Sep 11 15:25:03 2011
• URL: http://code.ros.org/trac/ros-pkg/ticket/5159

[hershwg]

[hersh] Fixed in r37937. Thanks.