Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed QWidget not defined bug in rviz_python_tutorial #41

Merged
merged 1 commit into from
May 10, 2018
Merged

Fixed QWidget not defined bug in rviz_python_tutorial #41

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions rviz_python_tutorial/myviz.py
View file
Open in desktop
Expand Up @@ -18,6 +18,10 @@
## python_qt_binding internally, so you should use it here as well.
from python_qt_binding.QtGui import *
from python_qt_binding.QtCore import *
try:
from python_qt_binding.QtWidgets import *
except ImportError:
pass
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the rationale behind doing a silent pass on import failure here? In what situation does this fail?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QApplication is in QtWidgets in Qt5. My intent is to import QtWidgets only when using Qt5


## Finally import the RViz bindings themselves.
import rviz
Expand Down