Python 3 compatibility changes #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -61,7 +61,8 @@ | |||
| g_goal_id = 1 | |||
|
|
|||
| def get_name_of_constant(C, n): | |||
| for k,v in C.__dict__.iteritems(): | |||
| for k in C.__dict__: | |||
| v = C.__dict__[k] | |||
There was a problem hiding this comment.
If you use the key and the value anyway you could just call .items().
|
@jonbinney thanks! Could you make the change to Thanks. |
|
Thanks guys! I've updated the change to |
|
@jonbinney thanks for updating the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tried these with python 2.7 also to make sure they don't break backwards compatibility
except Exception, foosyntax is nowexcept Exception as fooDict.iteritemsno longer exists in python3 (replaced with a lazyDict.items)