Stop using "__connection_header" in actionlib #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 on the change in this pull request. But we should only apply it to the indigo branch once that is available. |
| @@ -252,12 +260,12 @@ class ActionClient | |||
| return n_.subscribe(ops); | |||
| } | |||
|
|
|||
| void statusCb(const actionlib_msgs::GoalStatusArrayConstPtr& status_array) | |||
| void statusCb(const ros::MessageEvent<actionlib_msgs::GoalStatusArray>& status_array) | |||
There was a problem hiding this comment.
Shouldn't this signature be:
const ros::MessageEvent<actionlib_msgs::GoalStatusArray const>& status_array
|
Can you please update the pull request against indigo-devel which I have just created? |
| @@ -242,8 +250,8 @@ class ActionClient | |||
| return n_.advertise(ops); | |||
| } | |||
|
|
|||
| template<class M, class T> | |||
| ros::Subscriber queue_subscribe(const std::string& topic, uint32_t queue_size, void(T::*fp)(const boost::shared_ptr<M const>&), T* obj, ros::CallbackQueueInterface* queue) | |||
| template<class M, class T, class Evt> | |||
There was a problem hiding this comment.
Do you really need an explicit Evt template type? Can it not be derived automatically as MessageEvent<M const>?
|
This pull request fails several unit tests. |
dirk-thomas
added a commit
that referenced
this pull request
Feb 13, 2014
|
Closing in favor of #20. |
dirk-thomas
added a commit
that referenced
this pull request
Feb 14, 2014
replace usage of __connection_header with MessageEvent (#17)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we remove the "__connection_header" field from ROS messages (in C++), actionlib needs to be fixed to use the ros::MessageEvent interface. Attached is a tested patch that uses the correct interface.
For background on the removal, see:
ros/gencpp#12