switch to package format 2 #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wkentaro
reviewed
Aug 11, 2017
| @@ -1,4 +1,6 @@ | |||
| <package> | |||
| <?xml version="1.0"?> | |||
| <?xml-model href="http://download.ros.org/schema/package_format2.xsd" schematypens="http://www.w3.org/2001/XMLSchema"?> | |||
There was a problem hiding this comment.
I had error on debian:stretch, ubuntu:yakketyand ubuntu:zesty, and this causes error on finding nodelet by pluginlib.
- https://travis-ci.org/ros-perception/perception_pcl/jobs/263001942
- https://travis-ci.org/ros-perception/perception_pcl/jobs/263001943
root@536df0d8dd4b:~/catkin_ws# rospack find catkin
terminate called after throwing an instance of 'rospack::Exception'
what(): error parsing manifest of package bondcpp at /opt/ros/lunar/share/bondcpp/package.xml
Aborted
Is this a correct fix?
There was a problem hiding this comment.
I removed this line, and it fixes the error.
There was a problem hiding this comment.
Thanks @wkentaro for reporting. This looks like a problem to report upstream given that this package uses the format defined in REP140.
So it looks more like a rospack issue: this looks to be related ros/rospack#77.
Given that it works on xenial but not the later platforms my guess is that it's a tinyxml2 issue. They seem to have bumped the version significantly between xenial and zesty
libtinyxml2-dev | 2.2.0-1.1ubuntu1 | xenial/universe | amd64, arm64, armhf, i386, powerpc, ppc64el, s390x
libtinyxml2-dev | 4.0.1-1 | zesty/universe | amd64, arm64, armhf, i386, ppc64el, s390x
wkentaro
added a commit
to wkentaro/bond_core
that referenced
this pull request
Aug 11, 2017
I had error reported at ros#27 (comment).
wkentaro
added a commit
to wkentaro/bond_core
that referenced
this pull request
Aug 11, 2017
I had error reported at ros#27 (comment).
wkentaro
added a commit
to wkentaro/bond_core
that referenced
this pull request
Aug 11, 2017
I had error reported at ros#27 (comment).
wkentaro
added a commit
to wkentaro/bond_core
that referenced
this pull request
Aug 11, 2017
I had error reported at ros#27 (comment).
wkentaro
added a commit
to wkentaro/bond_core
that referenced
this pull request
Aug 11, 2017
I had error reported at ros#27 (comment).
wkentaro
added a commit
to wkentaro/bond_core
that referenced
this pull request
Aug 11, 2017
I had error reported at ros#27 (comment).
wkentaro
added a commit
to wkentaro/bond_core
that referenced
this pull request
Aug 11, 2017
I had error reported at ros#27 (comment).
wkentaro
added a commit
to wkentaro/bond_core
that referenced
this pull request
Aug 11, 2017
I had error reported at ros#27 (comment).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.