Ros2 devel #54
Ros2 devel #54
Conversation
…re, changes related to migration.
… build and test procedure, and changes related to migration.
… test procedure, and changes related to migration.
… not used in code.
…ltin_interfaces made to build and exec depends.
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
There was a problem hiding this comment.
This looks like a straightforward port. I know it's blocking for diagnostics, so it's probably okay to go out as is.
I do have some concern about prepending the apache license on some of these files, I'm not sure if that is valid behavior.
Also, potentially as an enhancement down the road, this should take advantage of lifecycle nodes, but that's probably not critical at this juncture.
| @@ -0,0 +1,245 @@ | |||
| // Copyright 2018 Open Source Robotics Foundation, Inc. | |||
There was a problem hiding this comment.
I don't know if prepending the license like this is valid?
|
Oh yeah, I was raising my concerns about this as well but didn’t address it in this PR. I’ll revert them to their original license. |
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
|
7117269 should remove the false declaration of Apache2. |
|
@mjcarroll do you mind taking another look on this? 🙏 |
|
|
testing
|
This is a continuation of #43 which hopefully some of the outstanding reviews addressed.