Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

escaping ROS_PACKAGE_NAME fails when set cmake version at rosconfig #584

Closed
dpinol opened this issue Jan 31, 2014 · 1 comment
Closed

escaping ROS_PACKAGE_NAME fails when set cmake version at rosconfig #584

dpinol opened this issue Jan 31, 2014 · 1 comment

Comments

@dpinol
Copy link

dpinol commented Jan 31, 2014

Related to ros/roscomm#245 :

Please try this:

  1. Create a "/opt/ros/hydro/share/ros/rosconfig.cmake" file with only this contents
cmake_minimum_required(VERSION 2.8.3)
  1. Create a dry package which uses a rosconsole macro and compile it (eg. https://github.com/dpinol/ros_tests/tree/master/cmake_policy) with "make VERBOSE=1". You'll see that it has the wrong scaping for the package name: -DROS_PACKAGE_NAME="'"cmake_policy"'"
    Compilation will fail.

thanks

@dirk-thomas
Copy link
Member

Moved to ros/ros#43.

cwecht pushed a commit to cwecht/catkin that referenced this issue Mar 20, 2018
As discussed in ros#584. The two functions behave completely identical for our purposes, so renaming for consistency with the rest of cartographer_ros.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants