Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make rostest build dependency in CMakeLists.txt optional #588

Closed
bulwahn opened this issue Feb 4, 2014 · 2 comments
Closed

make rostest build dependency in CMakeLists.txt optional #588

bulwahn opened this issue Feb 4, 2014 · 2 comments

Comments

@bulwahn
Copy link

bulwahn commented Feb 4, 2014

We want to make the rostest build dependency in the CMakeLists.txt of all ROS packages optional.

This shall been done by the refactoring the CMakeLists.txt from:
find_package(catkin REQUIRED COMPONENTS [...] roscpp rostest) [...] if(CATKIN_ENABLE_TESTING) [...] endif()

to:

find_package(catkin REQUIRED COMPONENTS [...] roscpp) [! drop rostest !] [...] if(CATKIN_ENABLE_TESTING) find_package(rostest) [! add this line in the CATKIN_ENABLE_TESTING conditional block !] [...] endif()

For commits addressing this task, their commit message shall refer to this issue by
make rostest in CMakeLists optional (ros/catkin#588).

This has been discussed on the ros-sig-buildsystem [1], and prepares for the roll-out of the REP 140 [2].

[1] https://groups.google.com/forum/#!topic/ros-sig-buildsystem/Ub7ktrLPSe0
[2] https://github.com/jack-oquin/rep/blob/master/rep-0140.rst

@dirk-thomas
Copy link
Member

We should not list that under catkin but under ros/rosdistro. I will move your ticket there.

@bulwahn
Copy link
Author

bulwahn commented Feb 4, 2014

Okay. Go ahead and please update the commit message to refer to the new issue.

cwecht pushed a commit to cwecht/catkin that referenced this issue Mar 20, 2018
The `io` component of PCL brings in VTK, which in turn creates a lot of CMake pollution (such as bringing in Qt, which is completely unnecessary for `cartographer_ros`).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants