fix catkin_find to not return path with '/.' suffix #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
| p = os.path.join(source_path, matching_packages[0]) | ||
| p = source_path | ||
| if matching_packages[0] != os.curdir: | ||
| p = os.path.join(p, matching_packages[0]) |
There was a problem hiding this comment.
This would be easier to read with an if else instead of a reassignment
if matching...
p = os.path.join(source_path, matched...
else
p = source_path
And should these be elseifs?
There was a problem hiding this comment.
Especially when the expressions get more complex I actually don't like the duplication in both branches. And in this case it is actually doing something and conditionally appending something where the single if logic makes sense.
Therefore I will keep it as is.
There was a problem hiding this comment.
I don't mind one style or the other.
|
Needs to be backported. |
dirk-thomas
added a commit
that referenced
this pull request
Apr 28, 2014
fix catkin_find to not return path with '/.' suffix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.