Mass bug: package.xml installation verification

[cottsay]

I've found that some plain cmake packages do not install package.xml files. REP 127 does not explicitly say that this is required, but rosdep is unable to detect if the package is present without it.

I used a postbuild check on my experimental buildfarm (http://csc.mcs.sdsmt.edu/jenkins/) to detect this.

TODO before closing this bug:

• Bugs should be opened against these packages
• The package.xml spec should be amended to require this Already in REP 136
• Debian buildfarm postbuild stability check for this (Mark packages with missing package.xml unstable ros-infrastructure/buildfarm#205)

Packages affected:

• bondpy bondpy: Add catkin_package call to CMakeLists.txt bond_core#3
• depth_image_proc_jsk_patch non-catkin packages don't install package.xml jsk-ros-pkg/jsk_common#344
• eigen_typekit eigen_typekit and kdl_typekit do not install package.xml orocos/rtt_geometry#12
• eml eml does not install package.xml ros-gbp/eml-release#1
• image_view_jsk_patch non-catkin packages don't install package.xml jsk-ros-pkg/jsk_common#344
• kdl_typekit eigen_typekit and kdl_typekit do not install package.xml orocos/rtt_geometry#12
• laser_filters_jsk_patch non-catkin packages don't install package.xml jsk-ros-pkg/jsk_common#344
• libuvc Missing package.xml patch for Indigo ros-drivers-gbp/libuvc-release#1
• oculus_sdk oculus_sdk does not install package.xml ros-visualization/oculus_sdk#2
• opencv2_doc opencv2_doc does not install package.xml ros-gbp/opencv2_doc-release#1
• openni_tracker_jsk_patch non-catkin packages don't install package.xml jsk-ros-pkg/jsk_common#344
• open_karto Add catkin_package call to CMakeLists.txt stwirth/open_karto#1
• rtt_typelib rtt_typelib does not install package.xml orocos-toolchain/rtt_typelib#1

Thanks!

[dirk-thomas]

Yes, to all three questions.

Regarding the last one: this will likely require a contribution from the community since we might not have the time to work on this any time soon.

[cottsay]

Thanks @dirk-thomas, I'll compile a definitive list of the packages and open bugs against them.

[wjwwood]

REP-0136 says that installing your package.xml is required:

http://www.ros.org/reps/rep-0136.html#installing-a-catkin-package-xml

[cottsay]

I was looking over the spec, and I have a quick question. Is the <buildtool_depend> tag (http://www.ros.org/reps/rep-0127.html#buildtool-depend-multiple) required?

If it is not (indicating that there is no build tool), would it not be impossible to install the package.xml, which is the responsibility of the build tool?

Is this tag necessary for metapackages (more specifically, do they need catkin installed at build time)?

Thanks!

[dirk-thomas]

Since both of these are using catkin at build time on the platform doing the build, yes, both of them require a buildtool dependency on catkin.

[dirk-thomas]

Is there any further progress on this? Poking other package maintainers? Can this overview package be closed?

Otherwise I would suggest to move this ticket to ros/rosdistro since it is not specific to catkin.

[tfoote]

They are all ticketed upstream. I'm not sure we can do much more.

[cottsay]

With ros-infrastructure/buildfarm#205 merged, they'll certainly know that it is an issue. I agree that there is nothing more to be done.

Closing :)

[dirk-thomas]

Thank you!