Only set catkin_* variables when being invoked with find_package COMPONENTS #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 tested locally on geometry. re backporting: This only fixes c++ unit tests which want the ifdefed tests. @bulwahn has made a good number of pull requests into hydro which have been merged. Geometry appears to be the first one noticed to regress without this patch. The case that will break is if there are people misusing find package and find_package(foo) which is a catkin package and then using the unmatched variables like ${catkin_LIBRARIES}. As this is more of a bug taking advantage of side effects from under the hood it's probably worth backporting. This will allow users to have conditional testing on hydro and not require forking to have it in indigo. |
|
+1 |
dirk-thomas
added a commit
that referenced
this pull request
May 5, 2014
…omponents Only set catkin_* variables when being invoked with find_package COMPONENTS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a necessary change to support ros/rosdistro#3010.
@tfoote @wjwwood Please review and consider potential side effects. Is it possible / reasonable to backport this? Otherwise it will force a lot of packages to have a separate indigo branch (which they might not yet have).