Increase code coverage #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ahcorde <ahcorde@gmail.com>
ahcorde
force-pushed
the
ahcorde/code_coverage
branch
from
6ccbaa5
to
bb35f98
Compare
|
Could you trigger tests and post the code coverage result here? Thanks |
|
@chapulina I run codecov in my personal account. It's 90.16% |
|
Thanks, @ahcorde . Do you know why the results are different between codecov and jenkins? |
chapulina
approved these changes
May 4, 2020
|
Not really, we will need to improve the coverage a little bit more. I will figure it out. |
|
@ahcorde did you run CI on this? It is causing new compiler warnings I think: https://ci.ros2.org/view/nightly/job/nightly_linux_debug/1544/gcc/new/ |
Merged
|
Please try to remember that in the future. Btw, the automated CI also caught this: http://build.ros2.org/job/Fpr__class_loader__ubuntu_focal_amd64/5/ It could be seen from this pr's merge button... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added some tests to increase the code coverage