Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate FindPoco.cmake to cmake_modules #21

Closed
mitchellwills opened this issue Nov 18, 2014 · 2 comments
Closed

Migrate FindPoco.cmake to cmake_modules #21

mitchellwills opened this issue Nov 18, 2014 · 2 comments
Assignees

Comments

@mitchellwills
Copy link

I was looking to potentially use the Poco library in one of my projects and I noticed that class_loader has it's own private copy of FindPoco. Is there any reason for this or can it be migrated to cmake_modules?

@mirzashah
Copy link
Member

class_loader was intended originally to be a ROS-agnostic package...but given that it's a ROS catkin package anyway...I'm not sure there's any reason for it anymore. Also at the time, there was no cmake_modules package

@esteve
Copy link
Member

esteve commented Nov 19, 2014

Sounds good, I'll submit a PR to https://github.com/ros/cmake_modules/ and move FindPoco.cmake there.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants