Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TabError: inconsistent use of tabs and spaces in indentation #155

Merged
merged 2 commits into from
Jan 10, 2020

Conversation

Rayman
Copy link
Contributor

@Rayman Rayman commented Dec 13, 2019

Python 3 is much more strict for spacing. I've replaced all 8
consecutive spaces with a tab. I did not touch the spacing inside the
messages as they are part of the message.

Python 3 is much more strict for spacing. I've replaced all 8
consecutive spaces with a tab. I did not touch the spacing inside the
messages as they are part of the message.
Copy link
Member

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our standard is to use spaces and not tabs in the ROS project. http://wiki.ros.org/PyStyleGuide please convert it the other way to remove the tabs.

@Rayman Rayman requested a review from tfoote January 10, 2020 09:55
@Rayman
Copy link
Contributor Author

Rayman commented Jan 10, 2020

I've replaces all tabs with spaces according to PEP 8. Note that the diff is now bigger. I've just tested that this PR still fixes the rosbag check inconsistent spaces error.

Copy link
Member

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for iterating it looks good to me.

@tfoote tfoote merged commit ed56571 into ros:jade-devel Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants