-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use c++11 instead of boost #21
Comments
Finding the correct version will be a challenge since neither this nor In |
The current target platforms for ROS are defined in REP 3 (http://www.ros.org/reps/rep-0003.html). For all previous ROS releases C++03 was the minimum requirement and and that's why it can currently not use C++11. Therefore it can only be considered for future releases. You might want to start a discussion about the minimum C++ version required for the next ROS version (k-turtle, May 2016). But please keep in mind that this implies that ROS would not be compilable anymore on platform which don't have a C++11 compatible compiler. |
The default version of gcc in Ubuntu 12.04 (Precise) doesn't support c++11, but it is supported in 14.04 (trusty) and up. Since the minimum supported Ubuntu version for Jade is trusty, perhaps we could do it for K-turtle? Should I start a thread on |
I'd suggest a PR to REP 3 with a compatible proposal for kinetic and announcement of the discussion on |
After looking briefly in the code it looks like that In other cases where the types are being exposed through the API it might be significantly more effort to update if every code using the API needs to be updated to. |
Indeed, I have started a discussion at ros/urdfdom#62 where boost shared pointers are used in the public API. |
In October, the ros2 branch implemented these changes: We've also decided that C++11 compatibility will be required for Kinetic. So it sounds like the way forward for this issue will be easy enough. |
@jacquelinekay thanks for the pointer to the |
fixed by #25 |
This package uses just a very small amount of boost, much less than urdfdom (related issue: ros/urdfdom#62 ). So it should be easier to use this as a test case for how to start the move to c++11. I have made the necessary changes in scpeters@255abf6 but I wanted to wait before submitting a pull request to ask what the new branch should be called and what numbering to use.
Some questions:
release-0.2
) and make the master branch use c++11?@wjwwood
The text was updated successfully, but these errors were encountered: