Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use c++11 instead of boost #25

Merged
merged 2 commits into from
Dec 18, 2015
Merged

Use c++11 instead of boost #25

merged 2 commits into from
Dec 18, 2015

Conversation

scpeters
Copy link
Contributor

@scpeters scpeters commented Dec 9, 2015

This package uses only a small amount of boost
for a mutex and scoped_lock.
These are replaced with std::mutex
and std::lock_guard from c++11.
Boost is removed as a dependency
and the c++11 compiler flag is added.

@scpeters
Copy link
Contributor Author

scpeters commented Dec 9, 2015

@scpeters
Copy link
Contributor Author

scpeters commented Dec 9, 2015

Fixes #21

@j-rivero
Copy link
Contributor

+1 amazing

@scpeters
Copy link
Contributor Author

I just noticed @jacquelinekay 's comment that the ros2 branch had another implementation of these changes by @wjwwood , with some extra fixes for Windows. I just merged with that branch in this pull request.

@j-rivero can you double-check the changes to CMakeLists.txt? Thanks

@j-rivero
Copy link
Contributor

@j-rivero can you double-check the changes to CMakeLists.txt? Thanks

Looks good to me. +1

wjwwood and others added 2 commits December 17, 2015 16:28
This package uses only a small amount of boost
for a mutex and scoped_lock.
These are replaced with std::mutex
and std::lock_guard from c++11.
Boost is removed as a dependency
and the c++11 compiler flag is added.

Some Windows fixes are included as well.
@scpeters
Copy link
Contributor Author

Ok, I'm squashing onto @wjwwood 's commit and will merge

scpeters added a commit that referenced this pull request Dec 18, 2015
Use c++11 instead of boost
@scpeters scpeters merged commit f375f48 into ros:master Dec 18, 2015
@scpeters scpeters deleted the cpp11 branch December 18, 2015 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants