use target include directories for gtest #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
|
@scpeters is there anything I can do to push this PR forward? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to https://github.com/ros2/ros2/issues/743
I think
tf2is running into conflicts when using console bridge from homebrew (v.0.4.3) vs the version installed by the ros2console_bridge_vendorpackage (v.0.4.1).My believe is that setting the global include directories for gtest might cause the trouble where an inconsistent state between library of
ament_cmake_gtestand theconsole_bridgegtest headers occurs.Signed-off-by: Karsten Knese karsten@openrobotics.org