Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

diagnostic_updater python API is not exported #10

Closed
mathias-luedtke opened this issue Oct 15, 2013 · 8 comments
Closed

diagnostic_updater python API is not exported #10

mathias-luedtke opened this issue Oct 15, 2013 · 8 comments

Comments

@mathias-luedtke
Copy link

catkin_python_setup() and corresponding setup.py are missing

@bricerebsamen
Copy link
Contributor

I attempted to fix the problem. I am not too familiar with this catkin python thingy though ... so I am keeping the issue open until someone can confirm things have been fixed.

@tfoote
Copy link
Member

tfoote commented Oct 16, 2013

A quick review of that looks right.

@mathias-luedtke
Copy link
Author

I can confirm the fix works for groovy-devel. Thanks.

@bricerebsamen
Copy link
Contributor

that is weird because I only made the change for hydro-devel. Can you elaborate? What did you observe exactly? I was also at loss at what to observe as a result of my changes...

@mathias-luedtke
Copy link
Author

Sorry for the confusion.. I have cherry-picked your commit back into groovy-devel locally for the test.
What I should have said instead: The commit works for groovy as well and it would be great if you backport it.

@rgariepy
Copy link

Works in hydro from src and a non-root install space.

@ahendrix
Copy link
Contributor

ahendrix commented Apr 8, 2014

This looks like it's resolved. Is it worth back porting this change to Groovy, or should I just close it?

@trainman419
Copy link
Contributor

Closing for inactivity. Please open a new ticket or a pull request if you would like this fix backported to Groovy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants