Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spin on node in diagnostic_updater example #120

Merged
merged 2 commits into from
Aug 23, 2019
Merged

Spin on node in diagnostic_updater example #120

merged 2 commits into from
Aug 23, 2019

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented Aug 22, 2019

This will allow manipulation and query of the parameters. Without this change, invoking ros2 param list hangs.

This will allow manipulation and query of the parameters.

Signed-off-by: Scott K Logan <logans@cottsay.net>
Copy link
Contributor

@Karsten1987 Karsten1987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

definitely needed!
Should be rclcpp::spin_some(node) though.

diagnostic_updater/src/example.cpp Outdated Show resolved Hide resolved
Co-Authored-By: Karsten Knese <Karsten1987@users.noreply.github.com>
@Karsten1987 Karsten1987 merged commit bdd789f into ros:ros2-devel Aug 23, 2019
Karsten1987 added a commit to boschresearch/ros2_diagnostics that referenced this pull request Aug 27, 2019
* Spin on node in diagnostic_updater example

This will allow manipulation and query of the parameters.

Signed-off-by: Scott K Logan <logans@cottsay.net>

* Update diagnostic_updater/src/example.cpp

Co-Authored-By: Karsten Knese <Karsten1987@users.noreply.github.com>
@cottsay cottsay deleted the ros2_example_spin branch June 3, 2020 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants