[ROS2] Enable multiple tasks publishing for diagnostic updater #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Karsten1987
approved these changes
Mar 1, 2021
|
@BasVolkers thanks for the patch and sorry for the long turnaround. This ticket flew under my radar. |
Karsten1987
pushed a commit
that referenced
this pull request
Mar 3, 2021
Karsten1987
added a commit
that referenced
this pull request
Mar 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the publish() function of the Updater() class in _diagnostic_updater.py seems bugged.
A DiagnosticStatus is only created for the last stat in msg, while it should be for every stat in msg.
This means that only a single DiagnosticStatus is published instead of all the DiagnosticStatus.
This Pull Request fixes this by creating a DiagnositcStatus in the for loop and appending it to the DiagnosticArray.
This is a copy of #181, but with target ros2-devel.