Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[diagnotics_analysis] fix type comparison for python3 #194

Merged

Conversation

mikaelarguedas
Copy link
Member

In python3, self._stats[name]['fields'].keys() returns a dict_keys object, so the comparison to a list is never True.

PS: the default branch of this depo is indigo-devel making it the default target for PRs, should it be noetic-devel instead ?

Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
@g-gemignani
Copy link
Collaborator

Thanks for the PR.
About the default branch, unfortunately I do not have the rights to do so. Maybe @trainman419 can do that?

@g-gemignani g-gemignani merged commit 786b24b into ros:noetic-devel Mar 20, 2021
@mikaelarguedas mikaelarguedas deleted the diagnostic_analysis_python3 branch March 20, 2021 17:38
@trainman419
Copy link
Contributor

Ok; I've updated the default branch to noetic-devel

@mikaelarguedas
Copy link
Member Author

Awesome, thank you both for the prompt reply 👍

@g-gemignani
Copy link
Collaborator

Thank you @trainman419

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants