Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linting additional package #268

Merged
merged 28 commits into from
Feb 15, 2023
Merged

Linting additional package #268

merged 28 commits into from
Feb 15, 2023

Conversation

ct2034
Copy link
Collaborator

@ct2034 ct2034 commented Dec 16, 2022 •
edited
Loading

  • fix found linting error?
  • Is format also linted?
  • Can we activate the linter for more pkgs?

@ct2034
linting additional package
a107205 
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
@ct2034
formatting fixes
002a4fe 
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
@ct2034
more formatting fixes
2220cd7 
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
@ct2034
sorting impots
7d04faf 
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
@ralph-lange ralph-lange added the ros2 PR tackling a ROS2 branch label Dec 19, 2022
@ct2034
empty
6c2c28c 
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
@ct2034
latest actions
1643d40 
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
@ct2034
no v in version
eb15a66 
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
@ct2034
skipping bugged linters
d0589c2 
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
@ct2034
Revert "skipping bugged linters"
1aff805 
This reverts commit d0589c2.
@ct2034 ct2034 mentioned this pull request Jan 9, 2023
Closed
ct2034 and others added 9 commits January 9, 2023 17:00
@ct2034
skipping the ros setup step
db3ecd0 
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
@ct2034
install rosdep manually
4e6a708 
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
@ct2034
removing pip installed linters
78ff233 
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
@ct2034

29bf182 
workaround for ament_pep257
workaround for ament_pep257

Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
@ct2034
fixin docstring problems
563aa0d 
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
@ct2034
latest action versions
1e24f0e 
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
@ct2034
skipping flake8
29f247b 
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
@ct2034 @ralph-lange
License fixes (ros#263)
c821e64 
* License fixes
* Adding Willow Garage times

Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
Co-authored-by: Ralph Lange <ralph.lange@de.bosch.com>
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
@ct2034 @ralph-lange
Adding READMEs to the repo (ros#270)
31a0a9f 
* Adding a repo-level readme
* An example aggregation
* A readme for the aggregator
* Common diagnostics readme
* A readme for the diagnostic updater
* A readme for the self_test package
* Maintainers unified
* Skip pep257 while it is unstable

Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
Co-authored-by: Ralph Lange <ralph-lange@users.noreply.github.com>
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
@ct2034 ct2034 force-pushed the add/linting_diagnostic_common_diagnostics branch from 05670e2 to 31a0a9f Compare January 25, 2023 10:03
ct2034 and others added 5 commits January 25, 2023 11:12
@ct2034
Empty commit
7b23e04 
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
@ct2034
Merge branch 'rolling' into add/linting_diagnostic_common_diagnostics
2c25e5c
@ct2034
fix for AttributeError: module 'lib' has no attribute 'X509_V_FLAG_CB…
bf6149e 
…_ISSUER_CHECK'

Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
@ct2034
using rclpy.try_shutdown to avoid occasional stacktrace like ...
6bd38b8 
rclpy._rclpy_pybind11.RCLError: failed to shutdown: rcl_shutdown already called on the given context, at /home/runner/work/diagnostics/diagnostics/ros_ws/src/ros2/rcl/rcl/src/rcl/init.c:241

Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
@ct2034
skipping flake8 for auto_lint
36d68a9 
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
@ct2034 ct2034 changed the base branch from stale/rolling to ros2 February 13, 2023 11:27
@ct2034
Merge branch 'ros2' into add/linting_diagnostic_common_diagnostics
7511335 
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
@ct2034
correct yaml
9046383 
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
@ct2034
exclude flake8
511d385 
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
@ct2034
fixing flake8 problems
ddfaaed 
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
@ct2034 ct2034 marked this pull request as ready for review February 13, 2023 13:52
ralph-lange
ralph-lange approved these changes Feb 15, 2023
View reviewed changes
Copy link
Collaborator

@ralph-lange ralph-lange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for activating the linter again!

@ct2034 ct2034 merged commit 5a3a922 into ros:ros2 Feb 15, 2023
@ct2034 ct2034 deleted the add/linting_diagnostic_common_diagnostics branch February 15, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ralph-lange ralph-lange ralph-lange approved these changes

Assignees
No one assigned
Labels
ros2 PR tackling a ROS2 branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ct2034 @ralph-lange