Use PYTHON_EXECUTABLE to generate config headers. #146
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All current
.cfg
files in the wild are executable and have shebang lines. Unfortunately, because they are invoked at build time, this is another instance where the specificpython
thatusr/bin/env python
leads to becomes important, especially in an environment like Ubuntu Focal, wherepython
is Python 2 (and may not even exist at all).In this case, it's easy to address— call the correct interpreter directly in the wrapper generated by
configure_file
. The Windows version already does something similar, so I've updated it to also use thePYTHON_EXECUTABLE
cmake var rather than justpython
.See related discussions in ros/catkin#1044, ros/ros_comm#1830, ros/roslisp#43
FYI @dirk-thomas