Fix python3 issue in a backward compatible way #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as reconfigure_gui doesnt exist since groovy, it's removed here instead of installed ros@1d3f3d5 dynparam dets installed using catkin_install_python to leverage the automatic rewriting of the shebang lines Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
|
This pull request has been mentioned on ROS Discourse. There might be relevant details there: https://discourse.ros.org/t/ros-noetic-ninjemys-release/14262/22 |
mjcarroll
approved these changes
Jun 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is written to be backportable to other ROS distributions.
It fixes 2 issues I faced trying to use dynparam in ROS Noetic
/usr/bin/env: ‘python’: No such file or directoryNameError: name 'file' is not definedThis is a less intrusive alternative to #156
This PR also removes the placeholder script
reconfigure_guithat has been introduced as a deprecation warning for the groovy release 1d3f3d5