Remove calls to string.{join,lower,upper} #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The functions are not present in Python 3.8. Signed-off-by: Gaël Écorchard <gael.ecorchard@cvut.cz>
gbiggs
reviewed
Feb 3, 2022
| @@ -41,12 +41,10 @@ | |||
| # Need to put sane error on exceptions | |||
| from __future__ import print_function | |||
|
|
|||
| import roslib; roslib.load_manifest("dynamic_reconfigure") | |||
There was a problem hiding this comment.
What is this line needed for?
There was a problem hiding this comment.
I found the article here.
https://answers.ros.org/question/115346/what-does-roslibload_manifest-do/
http://wiki.ros.org/PyStyleGuide
I don't know this package have a dependency that is still on rosbuild.
There was a problem hiding this comment.
Removing it seems reasonable, but not related to this PR. I think it should be done in a separate PR.
Signed-off-by: Gaël Écorchard <gael.ecorchard@cvut.cz>
gbiggs
approved these changes
Feb 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The functions are not present in Python 3.8.
Signed-off-by: Gaël Écorchard gael.ecorchard@cvut.cz