fix: Race condition on quickly setting and getting config #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes ros#187 by using the server's response to the set service to update the latest configuration.
|
Can you please provide a minimal, reproducible example that can be used to test this PR fixes the problem? |
|
Thanks for the test, which I got to fail without the fix and pass with the fix. Thanks also for the contribution! |
|
I need this fix on a ROS Melodic system as well. Should I make a new PR backporting this fix? What is the best way forward? |
rokusottervanger
deleted the
fix/187-race-condition-when-quickly-setting-and-getting-config
branch
rokusottervanger
added a commit
to nobleo/dynamic_reconfigure
that referenced
this pull request
Feb 4, 2022
* fix: Race condition on quickly setting and getting config fixes ros#187 by using the server's response to the set service to update the latest configuration. * test: add test for single threaded set and get using c++ client
|
We'll handle backporting to melodic. |
gbiggs
pushed a commit
that referenced
this pull request
Feb 19, 2022
* fix: Race condition on quickly setting and getting config fixes #187 by using the server's response to the set service to update the latest configuration. * test: add test for single threaded set and get using c++ client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #187 by using the server's response to the set service to update the latest configuration.