Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to reload parameters from a file generated by dumping #51

Closed
b1willaert opened this issue Feb 10, 2015 · 16 comments
Closed

Unable to reload parameters from a file generated by dumping #51

b1willaert opened this issue Feb 10, 2015 · 16 comments
Assignees

Comments

@b1willaert
Copy link

I am using ubuntu 14.04/Indigo from debs.

I am not using grouping. The generated yaml file contains all parameters twice as follows:

!!python/object/new:dynamic_reconfigure.encoding.Config
dictitems:
  parameter1: false
...
  groups: !!python/object/new:dynamic_reconfigure.encoding.Config
    dictitems:
      parameter1: false
...
      groups: !!python/object/new:dynamic_reconfigure.encoding.Config
        state: []
      id: 0
      parameters: !!python/object/new:dynamic_reconfigure.encoding.Config
        state: []
      parent: 0
      state: true
      type: ''
    state: []
state: []

The exact same issue has been posted on the ROS.answers too:
http://answers.ros.org/question/181915/dynamic_reconfigure-unable-to-reload-dumped-parameters/

@esteve esteve self-assigned this Feb 14, 2015
@esteve
Copy link
Member

esteve commented Feb 14, 2015

Does this only happen with nodelets or with nodes as well?

@b1willaert
Copy link
Author

I only tested it with nodes. So yes, it happens with nodes.

@pirobot
Copy link

pirobot commented Mar 15, 2015

I am experiencing the same issue, both under ROS Hydro/Ubuntu 12.04 and ROS Indigo/Ubuntu 14.04. The following error appears when dumping parameters to a file for either a node or nodelet and then trying to load them immediately after:

$ rosrun dynamic_reconfigure dynparam dump /my_node my_node.yaml
$ rosrun dynamic_reconfigure dynparam load /my_node my_node.yaml

error updating parameters: don't know parameter: groups

In addition to the error, the parameters are not loaded (just to be clear).

@l0g1x
Copy link

l0g1x commented Oct 9, 2015

Has anyone looked into this issue lately? It would be useful to re-load things like path planner parameters from adjusting values in rqt_reconfigure. Param server names may be different from dynamic reconfigure .cfg variable names in some packages, so that might be a issue if one wants to load the dumped dynamic reconfigure yaml to the ros param server (even though I dont think its possible right now?), for a quick restart where they left off.

@l0g1x
Copy link

l0g1x commented Dec 9, 2015

Can this one be added to the bug sqaush list? I can look into this but not until friday

@esteve
Copy link
Member

esteve commented Dec 9, 2015

@l0g1x sure, thanks for volunteering!

@esteve
Copy link
Member

esteve commented Dec 9, 2015

@l0g1x I just added it to the document, please claim it so that we can coordinate better.

https://docs.google.com/document/d/1DPZuBDyUyOVNkKCOtwpo-nxGba7aSJdvP6ncqRZOBEU/edit?usp=sharing

@l0g1x
Copy link

l0g1x commented Dec 9, 2015

Put my name on it!

Also, this may not be the correct place to ask this, but is there a REP or anything in place regarding rosparam and dynamic reconfigure parameter naming conventions? Im not sure if this would be useful for anyone else, but having a feature where you can dump 'tuned' variables using dynamic reconfigure into a yaml, that you then pass to say a launch file which loads the dumped 'tuned' parameters into the rosparam server as many nodes initialize themselves by grabbing rosparams. This cant really be done as many packages who do support dynamic reconfigure AND initialize by rosparam server parameters since the naming of variables between the two features is not consistent (for example move_base)

@renrut
Copy link

renrut commented Mar 1, 2016

@l0g1x you ever figure it out?

vagvaz added a commit to vagvaz/dynamic_reconfigure that referenced this issue May 11, 2016
@vagvaz
Copy link
Contributor

vagvaz commented May 27, 2016

HI I created a pull request it is a simple is not --> != change in the client

mikaelarguedas added a commit that referenced this issue Jun 12, 2016
…rs_from_file

fix issue #51 reloading parameters from dumped file
@mikaelarguedas
Copy link
Member

fixed in #61

@lindemeier
Copy link

I am experiencing this issue on Ubuntu 16.04 (kinetic).

!!python/object/new:dynamic_reconfigure.encoding.Config
dictitems:
  autoScale: true
  debayerLibraw: true
  groups: !!python/object/new:dynamic_reconfigure.encoding.Config
    dictitems:
      autoScale: true
      debayerLibraw: true
      groups: !!python/object/new:dynamic_reconfigure.encoding.Config
        state: []
      id: 0
      name: Default
      parameters: !!python/object/new:dynamic_reconfigure.encoding.Config
        state: []
      parent: 0
      rawBits: 16
      state: true
      streamingMode: false
      type: ''
      whiteBalanceCoeff_b: 1.0
      whiteBalanceCoeff_g0: 1.0
      whiteBalanceCoeff_g1: 1.0
      whiteBalanceCoeff_r: 1.0
    state: []
  rawBits: 16
  streamingMode: false
  whiteBalanceCoeff_b: 1.0
  whiteBalanceCoeff_g0: 1.0
  whiteBalanceCoeff_g1: 1.0
  whiteBalanceCoeff_r: 1.0
state: []

Loading the parameters produces this error:

error updating parameters: don't know parameter: groups

Removing the duplicates solves it

!!python/object/new:dynamic_reconfigure.encoding.Config
dictitems:
  autoScale: false
  debayerLibraw: true  
  rawBits: 16
  streamingMode: false
  whiteBalanceCoeff_b: 1.0
  whiteBalanceCoeff_g0: 0.5
  whiteBalanceCoeff_g1: 0.5
  whiteBalanceCoeff_r: 1.0
state: []

@jacquelinekay
Copy link

This fix persists in the debian because dynamic_reconfigure needs to be released for Kinetic.

@mikaelarguedas
Copy link
Member

The upcoming sync should propagate the fix to the main apt repo for all ros distributions

@Kaju-Bubanja
Copy link

This issue still exists in melodic, any release schedule for this issue?

@130s
Copy link
Member

130s commented Jan 14, 2020

My team has been troubled with this issue (and potentially other issues regarding dump feature) for a few years and internally have come up with a workaround, which has been causing a great amount of technical debt and new issues.

#61 seems to have become available since 1.5.44 on Kinetic back in 2016 (I'm on ROS K) but our problem has persisted.

I'm willing to provide more info but I'd request reopen this ticket (or I can open a separate one).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests